Fix Event Loop Blocks #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #943 +/- ##
=====================================
- Coverage 92% 92% -0%
=====================================
Files 298 298
Lines 18548 18560 +12
=====================================
+ Hits 17057 17059 +2
- Misses 1491 1501 +10 ☔ View full report in Codecov by Sentry. |
Closed
liquidsec
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #901.
This PR significantly speeds up scans by removing sources of event loop blockage, including a severe bug in
dnszonetransferthat could freeze the scan for upwards of ten seconds.In order to make identifying future asyncio bugs easier, this PR also separates out common function calls into named tasks for easier tracking.
Finally, the number of processes in the process pool has been reduced by 1 in an effort to prevent the process pool for competing with the main python process for CPU.